fix(core): Account for waiting jobs during shutdown #11338
Merged
+47
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivov
commented
Oct 22, 2024
| @@ -126,13 +126,23 @@ export class ScalingService { | |||
|
|
|||
| @OnShutdown(HIGHEST_SHUTDOWN_PRIORITY) | |||
| async stop() { | |||
| await this.queue.pause(true, true); // no more jobs will be picked up | |||
| const { instanceType } = this.instanceSettings; | |||
There was a problem hiding this comment.
The original issue was main waiting forever on waiting (not running) executions when there were no workers available during the 30s grace period during shutdown. The deeper issue was that main should not be waiting at all for already enqueued jobs during the grace period, i.e. we need to divide responsibilities during shutdown based on instance type.
n8n-assistant
bot
added
core
netroy
reviewed
Oct 22, 2024
tomi
approved these changes
Oct 22, 2024
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
pay-2129
|
| Run status |
|
| Run duration | 04m 28s |
| Commit |
|
| Committer | Iván Ovejero |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
458
|
| View all changes introduced in this branch ↗︎ | |
netroy
approved these changes
Oct 22, 2024
|
✅ All Cypress E2E specs passed |
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/n8n/issue/PAY-2129