-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(AI Agent Node): Make tools optional when using OpenAI model with Tools agent #11212
Merged
OlegIvaniv
merged 2 commits into
master
from
ai-316-remove-constraint-on-at-least-one-tool-for-tools-agent
Oct 21, 2024
Merged
feat(AI Agent Node): Make tools optional when using OpenAI model with Tools agent #11212
OlegIvaniv
merged 2 commits into
master
from
ai-316-remove-constraint-on-at-least-one-tool-for-tools-agent
Oct 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanpaul
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than my comment on the tests - this looks good!
packages/@n8n/nodes-langchain/nodes/agents/Agent/agents/ToolsAgent/execute.ts
Show resolved
Hide resolved
|
n8n Run #7458
Run Properties:
|
Project |
n8n
|
Run status |
Passed #7458
|
Run duration | 04m 18s |
Commit |
675697cebf: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 OlegIvaniv 🗃️ e2e/*
|
Committer | Oleg Ivaniv |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
1
|
Pending |
0
|
Skipped |
0
|
Passing |
458
|
…ool-for-tools-agent
|
burivuhster
approved these changes
Oct 21, 2024
✅ All Cypress E2E specs passed |
OlegIvaniv
deleted the
ai-316-remove-constraint-on-at-least-one-tool-for-tools-agent
branch
October 21, 2024 12:21
Merged
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Require Specific Output Format
is toggled for non-tools agentsRelated Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)