Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): Add descriptive header to projects /workflow #11203

Merged
merged 17 commits into from
Oct 31, 2024

Conversation

r00gm
Copy link
Contributor

@r00gm r00gm commented Oct 10, 2024

Summary

Add header above tabs in project /workflow view
image
image
image
image
image

Related Linear tickets, Github issues, and Community forum posts

PAY-1997

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Oct 10, 2024
@r00gm r00gm marked this pull request as ready for review October 21, 2024 14:07
@r00gm r00gm requested a review from cstuncsik October 21, 2024 14:08
@r00gm r00gm requested a review from cstuncsik October 22, 2024 06:50
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cstuncsik one example of how one test break when it's component code has not being changed

@r00gm r00gm requested a review from cstuncsik October 22, 2024 09:16
cstuncsik
cstuncsik previously approved these changes Oct 22, 2024
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Oct 22, 2024

n8n    Run #7624

Run Properties:  status check passed Passed #7624  •  git commit 02149a6b89: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 r00gm 🗃️ e2e/*
Project n8n
Branch Review pay-1997-update-project-tab-view
Run status status check passed Passed #7624
Run duration 04m 22s
Commit git commit 02149a6b89: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 r00gm 🗃️ e2e/*
Committer r00gm
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 460
View all changes introduced in this branch ↗︎

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

1 similar comment
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

3 similar comments
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

cstuncsik
cstuncsik previously approved these changes Oct 31, 2024
Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link
Contributor

✅ All Cypress E2E specs passed

@r00gm r00gm merged commit 5d19e8f into master Oct 31, 2024
34 checks passed
@r00gm r00gm deleted the pay-1997-update-project-tab-view branch October 31, 2024 11:43
@github-actions github-actions bot mentioned this pull request Oct 31, 2024
@janober
Copy link
Member

janober commented Oct 31, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants