Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New App Icon #8

Open
p-schneider opened this issue Dec 2, 2021 · 2 comments · May be fixed by #9 or #10
Open

New App Icon #8

p-schneider opened this issue Dec 2, 2021 · 2 comments · May be fixed by #9 or #10

Comments

@p-schneider
Copy link

p-schneider commented Dec 2, 2021

With Version 1.20 scrcpy now has a new icon -> Genymobile/scrcpy#1987
SVG:
new icon (svg)

PNG:
new icon (png)

So it looks like the scripts/generate-icon.ps1 file needs to be updated to reflect that change (instead of loading and converting the old xpm icon from version 1.18).

@tech189 tech189 linked a pull request Jan 7, 2022 that will close this issue
@tech189
Copy link

tech189 commented Jan 24, 2022

@n3rd4i if you have time could you take a look at my PR which adds the new icon? It's quite a small change :)

@p-schneider
Copy link
Author

p-schneider commented Jan 29, 2022

With the 1.22 Release today an "official" .ico file was added to scrcpy: https://github.com/Genymobile/scrcpy/blob/master/data/icon.ico
-> https://raw.githubusercontent.com/Genymobile/scrcpy/master/data/icon.ico
(It was added in december, but I just read about it in the 1.22 changelog.)

/data/icon.ico: MS Windows icon resource - 1 icon, 256x256 with PNG image data, 256 x 256, 8-bit/color RGBA, non-interlaced, 32 bits/pixel

So with that it makes no sense to maintain scripts/generate-icon.ps1 here because the "official" icon.ico file should be good enough.

@p-schneider p-schneider linked a pull request Apr 1, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants