Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(loging): Improve logging output of provider and get #932

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

flub
Copy link
Contributor

@flub flub commented Apr 4, 2023

This makes the logging output a lot better, driven by real-life
debugging. It introduces a few more spans and downgrades the
per-frame stuff to trace.

This makes the logging output a lot better, driven by real-life
debugging.  It introduces a few more spans and downgrades the
per-frame stuff to trace.
@flub
Copy link
Contributor Author

flub commented Apr 4, 2023

/netsim

@github-actions
Copy link

github-actions bot commented Apr 4, 2023

flub/improve-logging.80919111d422ab913d54a47151fe7c57da881a73
Perf report:

test case throughput_gbps
iroh_latency_200ms 1_to_1 2.46
iroh_latency_200ms 1_to_3 8.38
iroh_latency_200ms 1_to_5 10.06
iroh_latency_200ms 1_to_10 8.49
iroh_latency_200ms 2_to_2 5.89
iroh_latency_200ms 2_to_4 11.70
iroh_latency_200ms 2_to_6 15.31
iroh_latency_200ms 2_to_10 15.21
iroh_latency_20ms 1_to_1 2.63
iroh_latency_20ms 1_to_3 8.11
iroh_latency_20ms 1_to_5 9.77
iroh_latency_20ms 1_to_10 7.99
iroh_latency_20ms 2_to_2 5.59
iroh_latency_20ms 2_to_4 11.69
iroh_latency_20ms 2_to_6 15.34
iroh_latency_20ms 2_to_10 16.42
iroh 1_to_1 3.60
iroh 1_to_3 8.86
iroh 1_to_5 11.35
iroh 1_to_10 9.67
iroh 2_to_2 6.34
iroh 2_to_4 12.30
iroh 2_to_6 15.90
iroh 2_to_10 17.97

@b5
Copy link
Member

b5 commented Apr 4, 2023

can confirm output of provide is much nicer with this branch, especially with large directory trees

@flub flub merged commit 6ae709e into main Apr 4, 2023
@flub flub deleted the flub/improve-logging branch April 4, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants