ref: Remove duplicate read_lp implementation #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems like we ended up with two bits of code doing exactly the same. Clean it up. This settles on read_lp() as name since this is symmetric with write_lp() which writes bytes. This implementation inlines the functions a bit more as well, the entire function is still small and it is used often.
dignifiedquire
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like we ended up with two bits of code doing exactly the same.
Clean it up.
This settles on read_lp() as name since this is symmetric with
write_lp() which writes bytes. This implementation inlines the
functions a bit more as well, the entire function is still small and
it is used often.