feat: Show more numbers in human readable form #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This shows sizes in KiB, MiB etc. Also adds a few totals and transfer summaries.
src/main.rs
Outdated
| @@ -315,11 +315,20 @@ async fn provide_interactive( | |||
|
|
|||
| let (db, hash) = provider::create_collection(sources).await?; | |||
|
|
|||
| println!("Collection: {}\n", Blake3Cid::new(hash)); | |||
| out_writer | |||
There was a problem hiding this comment.
are you sure we want to push all this to stderr? seems to me that this is stdout content for the provider
There was a problem hiding this comment.
Ugh, good catch. I'm not sure at all. I guess this is "data" and not progress information so should go to stdout? But like the peer ID, auth token and ticket are also written using to OutWriter, and this seems to fall in that category to me and why I changed this. Are they wrong too?
There was a problem hiding this comment.
I think they are wrong too, yes
There was a problem hiding this comment.
Ok, updated them all to direct println! calls. PTAL
dignifiedquire
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shows sizes in KiB, MiB etc. Also adds a few totals and transfer
summaries.