feat: Remove Request.id from the protocol #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we now only issue a single request per stream this field was not used. Using it in the provider to identify requests would introduce complexity and overhead for the bookkeeping of request IDs. Instead remove the field from the protocol. The provider still has a use-case for identifying which request events relate to. It now uses the QUIC stream ID for this, but does not promise so on an API-level. This also simplifies the events since this new request_id is always known, while previously it was only known after having decoded the request message.
dignifiedquire
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we now only issue a single request per stream this field was not
used. Using it in the provider to identify requests would introduce
complexity and overhead for the bookkeeping of request IDs. Instead
remove the field from the protocol.
The provider still has a use-case for identifying which request events
relate to. It now uses the QUIC stream ID for this, but does not
promise so on an API-level. This also simplifies the events since
this new request_id is always known, while previously it was only
known after having decoded the request message.