refactor(iroh): move protocol relevant impls into node/protocols #2831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/2831/docs/iroh/ Last updated: 2024-10-24T09:40:27Z |
|
I think we should use a rpc protocol that is relatively isolated (like gossip, not docs (huge) and not blobs (mixed with tags)) and see if we can move the rpc protocol definition to the iroh-gossip crate and the client handler under a feature flag. This PR is still fine though... :-) |
dignifiedquire
force-pushed
the
refactor-rpc
branch
from
cf0033f
to
f9a0e42
Compare
rklaehn
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some internal refactorings