refactor(iroh-net): Failing to bind is not a Warning log #2815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the bind is required the call stack already makes sure that this is surfaced correctly. It is in fact entirely normal if IPv6 to fail to bind and this is already logged on INFO level. We do not need an additional WARN log for this. This also doesn't need to debug-log the error, anyhow's alternate logging mechanism is perfect for this.
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/2815/docs/iroh/ Last updated: 2024-10-18T14:23:11Z |
dignifiedquire
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the bind is required the call stack already makes sure that this is
surfaced correctly. It is in fact entirely normal if IPv6 to fail to
bind and this is already logged on INFO level. We do not need an
additional WARN log for this.
This also doesn't need to debug-log the error, anyhow's alternate
logging mechanism is perfect for this.
Breaking Changes
None
Notes & open questions
Change checklist