Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(iroh-base): clarify AddrInfoOptions a little #2813

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

flub
Copy link
Contributor

@flub flub commented Oct 18, 2024

Description

A user did get confused about this, so fair enough.

Breaking Changes

None

Notes & open questions

Closes #2802

Please review my comman use. I feel entirely incompetent in using
commas.

Change checklist

  • Self-review.
  • Documentation updates following the style guide, if relevant.
  • Tests if relevant.
  • All breaking changes documented.

A user did get confused about this, so fair enough.

Please review my comman use.  I feel entirely incompetent in using
commas.
Copy link

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/2813/docs/iroh/

Last updated: 2024-10-18T12:21:00Z

Copy link

Netsim report & logs for this PR have been generated and is available at: LOGS
This report will remain available for 3 days.

Last updated for commit: 4685ef0

@flub flub added this pull request to the merge queue Oct 18, 2024
Merged via the queue into main with commit a36970a Oct 18, 2024
27 of 28 checks passed
@divagant-martian divagant-martian deleted the flub/docs-addrinfooptions branch October 29, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[docs] Clarify AddrInfoOptions: all options will result in tickets that contain the NodeId
2 participants