refactor(iroh-net): Remove PathState::recent_pong() #2745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The field itself is also directly accessible with the same visibility as this function. Having two ways to get to this value is a bit confusing. And directly using the field makes it easier when checking users by following the references from rust-analyzer.
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/2745/docs/iroh/ Last updated: 2024-09-23T16:26:36Z |
divagant-martian
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The field itself is also directly accessible with the same visibility
as this function. Having two ways to get to this value is a bit
confusing. And directly using the field makes it easier when checking
users by following the references from rust-analyzer.
Breaking Changes
None
Notes & open questions
None
Change checklist
[ ] Documentation updates following the style guide, if relevant.[ ] Tests if relevant.[ ] All breaking changes documented.