Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(iroh-net): Document the keylog environment variable correctly #2655

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

flub
Copy link
Contributor

@flub flub commented Aug 21, 2024

Description

Also log the fact this is enabled on WARN level. This is pretty
important to notice.

Breaking Changes

none

Notes & open questions

Change checklist

  • Self-review.
  • Documentation updates following the style guide, if relevant.
  • [ ] Tests if relevant.
  • [ ] All breaking changes documented.

Also log the fact this is enabled on WARN level.  This is pretty
important to notice.
@flub flub requested a review from matheus23 August 21, 2024 13:57
Copy link

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/2655/docs/iroh/

Last updated: 2024-08-21T13:57:24Z

@dignifiedquire dignifiedquire added this to the v0.24.0 milestone Aug 21, 2024
@flub
Copy link
Contributor Author

flub commented Aug 21, 2024

@dignifiedquire why not just approve it? :D

@flub flub enabled auto-merge August 21, 2024 15:26
Copy link
Contributor

@divagant-martian divagant-martian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems a simple enough change. LGTM

@flub flub added this pull request to the merge queue Aug 21, 2024
Merged via the queue into main with commit c70caaf Aug 21, 2024
28 checks passed
@flub flub deleted the flub/sslkeylogfile branch October 4, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants