Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(iroh): Remove flume from iroh gossip #2542

Merged
merged 2 commits into from
Jul 24, 2024
Merged

Conversation

rklaehn
Copy link
Contributor

@rklaehn rklaehn commented Jul 24, 2024

Description

refactor(iroh): Remove flume from iroh gossip

Yes, I know there is a PR that touches gossip. But just let me do my purge.

Breaking Changes

None

Notes & open questions

None

Change checklist

  • Self-review.
  • Documentation updates following the style guide, if relevant.
  • Tests if relevant.
  • All breaking changes documented.

Yes, I know there is a PR that touches gossip. But just let me do my purge.
@rklaehn rklaehn changed the title Remove flume from iroh gossip refactor(iroh): Remove flume from iroh gossip Jul 24, 2024
@rklaehn rklaehn marked this pull request as ready for review July 24, 2024 12:38
@rklaehn rklaehn requested a review from Frando July 24, 2024 12:38
@rklaehn rklaehn added this pull request to the merge queue Jul 24, 2024
Merged via the queue into main with commit 2964569 Jul 24, 2024
30 checks passed
matheus23 pushed a commit that referenced this pull request Nov 14, 2024
## Description

refactor(iroh): Remove flume from iroh gossip

Yes, I know there is a PR that touches gossip. But just let me do my
purge.

## Breaking Changes

None

## Notes & open questions

None

## Change checklist

- [x] Self-review.
- [x] Documentation updates following the [style
guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text),
if relevant.
- [x] Tests if relevant.
- [x] All breaking changes documented.
@rklaehn rklaehn deleted the iroh-gossip-flume-purge branch November 20, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants