refactor(iroh-net): More renaming of endpoint to direct address #2515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The name "endpoint" is overloaded and we decided a while ago to not use it for things other than `iroh_net::Endpoint`. This further renames more places that were called endpoint with the new name we already introduced for them: direct address. The direct address naming is already used consistently on public APIs, this is only for internal consistency.
flub
added
refactor
matheus23
reviewed
Jul 17, 2024
matheus23
reviewed
Jul 17, 2024
matheus23
reviewed
Jul 17, 2024
divagant-martian
approved these changes
Jul 17, 2024
Some more re-namings and docs tweaks Co-authored-by: Divma <[email protected]> Co-authored-by: Philipp Krüger <[email protected]>
|
thanks for all the additional suggestions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The name "endpoint" is overloaded and we decided a while ago to not
use it for things other than
iroh_net::Endpoint. This furtherrenames more places that were called endpoint with the new name we
already introduced for them: direct address. The direct address
naming is already used consistently on public APIs, this is only for
internal consistency.
Breaking Changes
metric changed:
magicsock::metrics::Metrics::update_endpoints->Metrics::update_direct_addrs.Notes & open questions
Change checklist