Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): separate out android builds & disable netbsd #2435

Merged
merged 18 commits into from
Jul 1, 2024
Merged

Conversation

Arqu
Copy link
Collaborator

@Arqu Arqu commented Jul 1, 2024

Description

Disables the netbsd build due to sudden issues with cross and linking.
Android separated out for the same reason but now builds directly without cross.

Breaking Changes

Notes & open questions

Change checklist

  • Self-review.
  • Documentation updates if relevant.
  • Tests if relevant.
  • All breaking changes documented.

@Arqu Arqu marked this pull request as ready for review July 1, 2024 12:11
@Arqu Arqu requested review from flub and dignifiedquire and removed request for flub July 1, 2024 12:11
@Arqu Arqu self-assigned this Jul 1, 2024
@Arqu Arqu added the ci continous integration label Jul 1, 2024
@Arqu Arqu requested a review from flub July 1, 2024 12:14
@Arqu Arqu changed the title chore(ci): separate out android builds chore(ci): separate out android builds & disable netbsd Jul 1, 2024
ANDROID_NDK_HOME: ${{ steps.setup-ndk.outputs.ndk-path }}
run: |
cargo install cargo-ndk
cargo ndk --target aarch64-linux-android build
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can do the other android targets in this setup as well, would be more consistent

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lemme try

@Arqu Arqu requested a review from dignifiedquire July 1, 2024 12:54
@Arqu Arqu added this pull request to the merge queue Jul 1, 2024
Merged via the queue into main with commit 002f5d5 Jul 1, 2024
25 checks passed
@Arqu Arqu deleted the arqu/android_builds branch July 1, 2024 13:37
matheus23 pushed a commit that referenced this pull request Nov 14, 2024
## Description

Disables the netbsd build due to sudden issues with cross and linking. 
Android separated out for the same reason but now builds directly
without cross.

## Breaking Changes

<!-- Optional, if there are any breaking changes document them,
including how to migrate older code. -->

## Notes & open questions

<!-- Any notes, remarks or open questions you have to make about the PR.
-->

## Change checklist

- [ ] Self-review.
- [ ] Documentation updates if relevant.
- [ ] Tests if relevant.
- [ ] All breaking changes documented.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci continous integration
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants