feat(iroh)!: remove node events #2274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've looked everywhere, am not using this. I'm ok with removing |
dignifiedquire
force-pushed
the
feat-remove-node-events
branch
from
92e3b31
to
b777472
Compare
|
was about to review but there are some conflicts fyi |
These seem to be mostly unused by consumers, and add complexity.
This fixes the tests, but there is still an error in the logs: 2024-05-13T07:20:51.152002Z ERROR iroh::node::builder: Error getting doc hashes: sending to iroh_docs actor failed
it happens during shutdown if the tasks stop in slightly different order
dignifiedquire
force-pushed
the
feat-remove-node-events
branch
from
5e2f512
to
17a4ad1
Compare
|
@divagant-martian ready for review |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These seem to be mostly unused by consumers, and add complexity.
Breaking Changes
iroh::node::Eventiroh::node::Node::subscribeNotes