fix(iroh-net): do not log as error if client disconnects from relay #2259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frando
force-pushed
the
fix/iroh-net-relay-logging-eof
branch
from
0927e85
to
580cf33
Compare
dignifiedquire
approved these changes
May 2, 2024
Frando
added a commit
that referenced
this pull request
May 2, 2024
…2259) ## Description In the relay server, we currently log all connection failures with `error` severity. This means that whenever a node disconnects while still in the TLS handshaking phase, we get an error log.: ``` 2024-05-02T09:00:38.443215Z ERROR relay server{me=svfacrfjgmv7fjeu}:relay-http-serve:conn{peer=127.0.0.1:33596}: iroh_net::relay::http::server: [HTTPS] relay: failed to handl e connection: TLS[manual] accept ``` This however is a perfectly fine thing, a node may decide to abort the connection to a relay whenever it pleases. Especially in tests we often shutdown while still in the process of connecting to a relay. This is annoying, because the `error` severity indicates things being wrong (especially with the stack traces we print on error logs in the CI). This PR checks if the error is a EOF and if so only prints it as a debug log. ## Breaking Changes <!-- Optional, if there are any breaking changes document them, including how to migrate older code. --> ## Notes & open questions <!-- Any notes, remarks or open questions you have to make about the PR. --> ## Change checklist - [x] Self-review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the relay server, we currently log all connection failures with
errorseverity. This means that whenever a node disconnects while still in the TLS handshaking phase, we get an error log.:This however is a perfectly fine thing, a node may decide to abort the connection to a relay whenever it pleases. Especially in tests we often shutdown while still in the process of connecting to a relay. This is annoying, because the
errorseverity indicates things being wrong (especially with the stack traces we print on error logs in the CI).This PR checks if the error is a EOF and if so only prints it as a debug log.
Breaking Changes
Notes & open questions
Change checklist