refactor: rustc beta is stricter again wrt imports and unused code #2185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some more unused code and duplicate imports detected by the beta compiler.
dignifiedquire
approved these changes
Apr 15, 2024
ppodolsky
pushed a commit
to izihawa/iroh
that referenced
this pull request
Apr 20, 2024
…0-computer#2185) ## Description Some more unused code and duplicate imports detected by the beta compiler. ## Notes & open questions Are the examples sufficiently tested by CI? ## Change checklist - [x] Self-review. - [x] Documentation updates if relevant. - [x] Tests if relevant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some more unused code and duplicate imports detected by the beta
compiler.
Notes & open questions
Are the examples sufficiently tested by CI?
Change checklist