refactor(iroh-net): Delete some unused testing infrastructure #2028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Once netcheck has managed to establish an external IP address there is no need to further wait on the portmapper. The results are already useful. If later the portmapper manages to get something done the magicsock will react to that and make use of it.
This came from the tailscale code but we never seem to have used it and our routers haven't exploded yet.
dignifiedquire
approved these changes
Feb 15, 2024
fubuloubu
pushed a commit
to ApeWorX/iroh
that referenced
this pull request
Feb 21, 2024
…puter#2028) ## Description This came from the tailscale code but we never seem to have used it and our routers haven't exploded yet. ## Notes & open questions Admittedly it would be nice not to keep hitting so many external things on the network. But our entire testsuite would need a big review for that. ## Change checklist - [x] Self-review. - [x] Documentation updates if relevant. - [x] Tests if relevant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This came from the tailscale code but we never seem to have used it
and our routers haven't exploded yet.
Notes & open questions
Admittedly it would be nice not to keep hitting so many external
things on the network. But our entire testsuite would need a big
review for that.
Change checklist