refactor: download and export structure and progress events #2003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frando
force-pushed
the
refactor/download-progress
branch
5 times, most recently
from
290da22 to
3bab9a2
Compare
Frando
changed the title
Frando
force-pushed
the
refactor/download-progress
branch
from
3bab9a2 to
cced101
Compare
Frando
force-pushed
the
refactor/download-progress
branch
from
cced101 to
ca9edb8
Compare
dignifiedquire
approved these changes
Feb 7, 2024
fubuloubu
pushed a commit
to ApeWorX/iroh
that referenced
this pull request
Feb 21, 2024
…ter#2003) ## Description This PR has a number of cleanups regarding download and export functionality: * We currently have an enum `DownloadProgress` which contains events for both downloading a blob and for exporting a blob from the node's blob store to files on the local filesystem. This PR moves the export progress events into an `ExportProgress` enum. * The code to export blobs to the local file system is moved from `iroh` to `iroh-bytes` * Code duplication around export progress is reduced and a couple of RPC and client structs are cleaned up accordingly ## Notes & open questions <!-- Any notes, remarks or open questions you have to make about the PR. --> ## Change checklist - [x] Self-review. - [x] Documentation updates if relevant. - [ ] Tests if relevant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR has a number of cleanups regarding download and export functionality:
DownloadProgresswhich contains events for both downloading a blob and for exporting a blob from the node's blob store to files on the local filesystem. This PR moves the export progress events into anExportProgressenum.irohtoiroh-bytesNotes & open questions
Change checklist