fix: build successfully from cargo vendor tarball
#1932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
flub
approved these changes
Jan 8, 2024
|
thanks for caring! |
fubuloubu
pushed a commit
to ApeWorX/iroh
that referenced
this pull request
Feb 21, 2024
## Description closes n0-computer#1931 Fixes the broken build when building from the vendored tarball produced by `cargo vendor`. The problem was with a config in `watchable v1.1.1` and was fixed in `watchable v1.1.2` (https://github.com/khonsulabs/watchable/releases/tag/v1.1.2). ## Notes & open questions ## Change checklist Co-authored-by: Floris Bruynooghe <[email protected]>
matheus23
pushed a commit
that referenced
this pull request
Nov 14, 2024
## Description closes #1931 Fixes the broken build when building from the vendored tarball produced by `cargo vendor`. The problem was with a config in `watchable v1.1.1` and was fixed in `watchable v1.1.2` (https://github.com/khonsulabs/watchable/releases/tag/v1.1.2). ## Notes & open questions ## Change checklist Co-authored-by: Floris Bruynooghe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #1931
Fixes the broken build when building from the vendored tarball produced by
cargo vendor. The problem was with a config inwatchable v1.1.1and was fixed inwatchable v1.1.2(https://github.com/khonsulabs/watchable/releases/tag/v1.1.2).Notes & open questions
Change checklist