refactor: client Entry
with methods to read content
#1854
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a
iroh::client::Entry
struct which wraps theiroh_sync::Entry
and adds methods to read the content of the entry. Reading the entry needs a reference to either aDoc<C>
or theIroh<C>
client (both work equally).@flub mentioned that this is missing from the expected API. I started this at the hack session but didn't get very far but now it's in a good shape IMO.
Notes & open questions
Change checklist