feat(net): add Magicsock::network_change
#1845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows notifying `iroh-net` when the network has likely changed. Usually this is only needed on android, as on all other OSes this is automatically detected.
13 tasks
link2xt
approved these changes
Nov 26, 2023
There was a problem hiding this comment.
Tested with Android, switching between LTE and Wi-Fi works now on deltachat/deltachat-core-rust#5041
|
Is it fine to call this on non-Android platforms as well because it is debounced anyway? If both the iroh-using app and iroh detect network change, this would not result in double STUN request, right? |
It should be fine now, yes. The original version I had would not have been, but now that it is fed properly through the internal detector, feel free to call it unconditionally |
flub
approved these changes
Nov 27, 2023
Co-authored-by: Floris Bruynooghe <[email protected]>
link2xt
reviewed
Nov 27, 2023
Co-authored-by: link2xt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows notifying
iroh-netwhen the network has likely changed.Usually this is only needed on android, as on all other OSes this is automatically detected.