Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(iroh): remove request token #1828

Merged
merged 4 commits into from
Nov 24, 2023
Merged

Conversation

rklaehn
Copy link
Contributor

@rklaehn rklaehn commented Nov 23, 2023

Description

Removes the request token from iroh-bytes, and everywhere else

Notes & open questions

Ticket format changes. Do we care?

Change checklist

  • Self-review.
  • Documentation updates if relevant.
  • Tests if relevant.

@divagant-martian divagant-martian changed the title Remove request token refactor(iroh): remove request token Nov 24, 2023
@divagant-martian
Copy link
Contributor

divagant-martian commented Nov 24, 2023

quick rg "request token" -i gives me

iroh/src/commands/blob.rs
260:                // TODO: This is where we are missing the request token from the running

iroh-bytes/src/protocol.rs
325://! # Request tokens
327://! Request tokens are an optional feature of the protocol. They are opaque byte
329://! request tokens to implement request level authorization.

Also

Ticket format changes. Do we care?

I don't think so, we haven't versioned them so I think it's fine

Copy link
Contributor

@divagant-martian divagant-martian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@divagant-martian divagant-martian added this pull request to the merge queue Nov 24, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 24, 2023
@divagant-martian divagant-martian added this pull request to the merge queue Nov 24, 2023
Merged via the queue into main with commit 1dfb7ac Nov 24, 2023
@dignifiedquire dignifiedquire deleted the reomve-request-token branch November 24, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants