fix(net): do not dial regions in parallel #1736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are supposed to be dialed in order, not in parallel. This should also fix the warnings in the logs about aborted dials.
|
So what does dialing a region mean anyway? And in what order will they be dialed? Ah, this is about multiple addrs in a single region. Do we have that at all? I thought we had 1 derper in region 1 and 1 in region 2, and that's it? |
|
Yes this doesn't really trigger currently, as we do not have multiple nodes in a region setup. But if we do, it is still better to dial one by one, as we only need one. The order is based on how the config is done. |
rklaehn
approved these changes
Oct 26, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
matheus23
pushed a commit
that referenced
this pull request
Nov 14, 2024
These are supposed to be dialed in order, not in parallel. This should also fix the warnings in the logs about aborted dials.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are supposed to be dialed in order, not in parallel.
This should also fix the warnings in the logs about aborted dials.