ref(iroh-net): Improve how STUN probes are run #1642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves the branches taken when stun probes need to be run: - If we don't have an appropriate socket, abort the entire probe set. - If we didn't send the probe fully, error. - In case of a plain send error: log it.
|
Let's get this merged. Though I can't approve my own PR... |
|
@dignifiedquire ping |
dignifiedquire
approved these changes
Dec 1, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This improves the branches taken when stun probes need to be run:
If we don't have an appropriate socket, abort the entire probe set.
If we didn't send the probe fully, error.
In case of a plain send error: log it.
Notes & open questions
This is probably more how this code should look like.
@dignifiedquire feel free to take this over and make any tweaks you
feel like as I'm no supposed to distract myself with this... ;)
Change checklist