Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(baomap): drop all baomap logging to debug or lower #1562

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

b5
Copy link
Member

@b5 b5 commented Oct 2, 2023

Description

We've decided that INFO logging level & above should be reserved for node operators that are at least familiar with iroh's different subsystems, but not engineering internals.

This is less than ideal on node startup:
Screenshot 2023-10-02 at 3 53 19 PM

So, drop to debug level.

Notes & open questions

Change checklist

  • Self-review.
  • Documentation updates if relevant.
  • Tests if relevant.

@b5 b5 added the _c-iroh-legacy Formerly big iroh node with all protocols label Oct 2, 2023
@b5 b5 requested a review from rklaehn October 2, 2023 19:55
@b5 b5 self-assigned this Oct 2, 2023
@b5 b5 requested a review from divagant-martian October 2, 2023 19:55
@b5 b5 marked this pull request as ready for review October 2, 2023 19:55
Copy link
Contributor

@flub flub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, we can always bring some back if this proved to be too broad.

@b5 b5 added this pull request to the merge queue Oct 3, 2023
Merged via the queue into main with commit 06b4ac7 Oct 3, 2023
@dignifiedquire dignifiedquire deleted the chore_baomap_logging_to_debug branch October 3, 2023 18:08
@b5 b5 added this to the v0.7.0 milestone Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
_c-iroh-legacy Formerly big iroh node with all protocols
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants