Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out what to do with request tokens and documents/sync #1519

Closed
Tracked by #1490
Frando opened this issue Sep 25, 2023 · 1 comment
Closed
Tracked by #1490

Figure out what to do with request tokens and documents/sync #1519

Frando opened this issue Sep 25, 2023 · 1 comment

Comments

@Frando
Copy link
Member

Frando commented Sep 25, 2023

I was having a look at the CLI start vs add etc - and re-noticed that we have a concept of RequestToken in iroh-bytes, which has 2 issues atm:

  1. It is not supported in docs at all (i.e. if you set a request token during node startup, docs cannot exchange content)
  2. with the CLI we only support creating a ticket with an embedded token for data added directly with iroh start (i.e. the old provide flow), but not for data added later with iroh add

Point 2) should be easy enough to solve by exposing ticket creation over the RPC (iroh.blobs.ticket(hash) or so). However about 1) I'm unsure. For release we should add to the notes though that sync is incompatible with --request-token

@github-project-automation github-project-automation bot moved this to 📋 Backlog - unassigned issues in iroh Sep 25, 2023
@Frando Frando mentioned this issue Sep 26, 2023
29 tasks
@dignifiedquire
Copy link
Contributor

Closing as stale

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in iroh Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

4 participants