fix(sync): fix PeerData
encoding, neighbor events, better & predictable tests
#1513
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NodeAddr
#1506 introduced a bug: ThePeerData
was encoded from thePeerAddr
(including the peer id) but decoded toAddrInfo
(without the peer id). So it failed, and dialing peers failed. It only did not matter much because most tests use tickets separately, so do not rely on thePeerData
gossip.sync_full_basic
not flakey anymore (hopefully). the main change is that for some events, we don't care about the exact order in tests anymore, because the exact order is too unpredictable timing-wise for things that happen concurrently. instead they are matched in chunks.Change checklist
Replaces #1512