Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update instructions for running rust examples #1511

Merged
merged 2 commits into from
Sep 21, 2023
Merged

docs: update instructions for running rust examples #1511

merged 2 commits into from
Sep 21, 2023

Conversation

b5
Copy link
Member

@b5 b5 commented Sep 21, 2023 •
edited
Loading

Description

discord user drhongo pointed out that our example instructions are out of date. This updates.

Change checklist

  • Self-review.
  • Documentation updates if relevant.
  • Tests if relevant.

@b5 b5 added docs Improvements or additions to documentation c-iroh labels Sep 21, 2023
@b5 b5 self-assigned this Sep 21, 2023
@b5 b5 requested a review from ramfox September 21, 2023 21:09
@b5 b5 marked this pull request as ready for review September 21, 2023 21:09
@b5 b5 added this to the v0.6.0 milestone Sep 21, 2023
ramfox
ramfox approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@ramfox ramfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one re-phrasing suggestion, otherwise LGTM!

iroh/README.md Outdated Show resolved Hide resolved
@b5 b5 enabled auto-merge September 21, 2023 22:43
@b5 b5 added this pull request to the merge queue Sep 21, 2023
Merged via the queue into main with commit 1bf55db Sep 21, 2023
15 checks passed
@dignifiedquire dignifiedquire deleted the fix-example-instructions branch November 1, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramfox ramfox ramfox approved these changes

Assignees

@b5 b5

Labels
c-iroh docs Improvements or additions to documentation
Projects
iroh
Archived in project
Milestone
v0.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@b5 @ramfox