test: Introduce iroh-test with common logging infrastructure #1365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code was copy-pasted around too much. This takes a simple and clean approach to this by creating a new crate which is used as a dev-dependency of all the other crates. The upside is there is no messing about with cargo features and delicate matching versions. The main downside is that it can not provide testing utilities which build on the code in the other crates. Most notable this is currently the testing derp server.
flub
requested review from
dignifiedquire,
Frando,
rklaehn,
ramfox and
divagant-martian
ramfox
approved these changes
Aug 16, 2023
- add version to dependency lines - add description to crate - add license info to readme
flub
requested review from
dignifiedquire
and removed request for
Frando,
rklaehn and
divagant-martian
dignifiedquire
approved these changes
Aug 24, 2023
matheus23
pushed a commit
that referenced
this pull request
Nov 14, 2024
## Description This code was copy-pasted around too much. This takes a simple and clean approach to this by creating a new crate which is used as a dev-dependency of all the other crates. The upside is there is no messing about with cargo features and delicate matching versions. The main downside is that it can not provide testing utilities which build on the code in the other crates. Most notable this is currently the testing derp server. ## Notes & open questions This skirts around the tricky bits of adding such a common module: The testing derp server is still copy-pasted around. I think this is fine, because solving that is ugly. Let's see if any other code ends up in this crate or if the majority needs a more complicated solution anyway. This also doesn't introduce a general *published* iroh-common crate (or whatever it would be named). This might also be useful but affects the public API and introduces other questions. There's no harm in considering this to be an entirely independent problem and to later add such a module as well as this one. ## Change checklist - [x] Self-review. - [x] Documentation updates if relevant. - [x] Tests if relevant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This code was copy-pasted around too much. This takes a simple and
clean approach to this by creating a new crate which is used as a
dev-dependency of all the other crates.
The upside is there is no messing about with cargo features and
delicate matching versions.
The main downside is that it can not provide testing utilities which
build on the code in the other crates. Most notable this is currently
the testing derp server.
Notes & open questions
This skirts around the tricky bits of adding such a common module: The
testing derp server is still copy-pasted around. I think this is
fine, because solving that is ugly. Let's see if any other code ends
up in this crate or if the majority needs a more complicated solution
anyway.
This also doesn't introduce a general published iroh-common crate
(or whatever it would be named). This might also be useful but
affects the public API and introduces other questions. There's no
harm in considering this to be an entirely independent problem and to
later add such a module as well as this one.
Change checklist