test(flaky): Add timeouts to gossip smoke test #1364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frando
force-pushed
the
flub/gossip-flaky-timeout
branch
from
1702807
to
61cead2
Compare
Frando
approved these changes
Aug 16, 2023
Frando
approved these changes
Aug 16, 2023
This test is seen to be flaky on CI and just spins forever until CI times out and gives up. - This improves the ordering to improve the flakyness. - It adds timeouts to the test itself we should see the test fail instead of spin forever. And as a failed test we should get logs from CI. Logs are probably needed to figure out why this is flaky.
flub
force-pushed
the
flub/gossip-flaky-timeout
branch
from
89de51f
to
1aeda26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This test is seen to be flaky on CI and just spins forever until CI
times out and gives up. By adding timeouts to the test itself we
should see the test fail instead of spin forever. And as a failed
test we should get logs from CI. Logs are probably needed to figure
out why this is flaky.
Notes & open questions
Change checklist