Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup variable and generic naming #1355

Closed
Frando opened this issue Aug 15, 2023 · 2 comments
Closed

Cleanup variable and generic naming #1355

Frando opened this issue Aug 15, 2023 · 2 comments
Labels
refactor a change that neither fixes a bug nor adds a feature

Comments

@Frando
Copy link
Member

Frando commented Aug 15, 2023

After #1216 is merged we should settle the naming of the bao store and the doc store in variables, struct fields and generics. Currently it is very inconsistent because things were not changed to keep rebasing feasible.

Here's a first suggestion:

  • BAO store: blobs, blob_store or bao_store? with generic B
  • Docs store: docs or docs_store? with generic D
@github-project-automation github-project-automation bot moved this to 📋 Backlog - unassigned issues in iroh Aug 15, 2023
@ramfox
Copy link
Contributor

ramfox commented Sep 25, 2023

@rklaehn @Frando did this get straightened out?

@dignifiedquire
Copy link
Contributor

this happened over the last PRs

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in iroh Oct 18, 2023
@dignifiedquire dignifiedquire added the refactor a change that neither fixes a bug nor adds a feature label Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor a change that neither fixes a bug nor adds a feature
Projects
iroh
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Frando @dignifiedquire @ramfox