refactor(iroh-net): Always attach tracing spans to spawned tasks #1299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is another commit that keeps fine-tuning our logging. - Most importantly this consistently attaches spans when tasks are spawned. This threads togehther a lot more context. - As a general rule spawned tasks get info_span!(), otther spans get debug_span!() - protmapper report is logged on info in reportgen now, just as the other sub-reports. - MagicSock::poll_recv logs number of datagrams on trace now instead of info. This is expected to be a lot. A new metric is added to keep track of this as well.
flub
force-pushed
the
flub/logging-spawn-spans
branch
from
630b53b to
4b3cd23
Compare
Arqu
approved these changes
Jul 26, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is another commit that keeps fine-tuning our logging.
Most importantly this consistently attaches spans when tasks are
spawned. This threads togehther a lot more context.
As a general rule spawned tasks get info_span!(), otther spans get
debug_span!()
protmapper report is logged on info in reportgen now, just as the
other sub-reports.
MagicSock::poll_recv logs number of datagrams on trace now instead
of info. This is expected to be a lot. A new metric is added to
keep track of this as well.
Notes & open questions
Change checklist
Documentation updates if relevant.Tests if relevant.