Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(iroh): error when path does not exist #1146

Merged
merged 1 commit into from
Jun 28, 2023
Merged

fix(iroh): error when path does not exist #1146

merged 1 commit into from
Jun 28, 2023

Conversation

dignifiedquire
Copy link
Contributor

Fixes #1068

@flub
Copy link
Contributor

flub commented Jun 28, 2023

my guess is your test failures are affected by point 5 of #1145

@flub
Copy link
Contributor

flub commented Jun 28, 2023

or not? some appear to be passing?

@dignifiedquire dignifiedquire merged commit c1b674f into main Jun 28, 2023
@dignifiedquire dignifiedquire deleted the fix-provide-invalid-path branch June 28, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flub flub flub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

iroh provide gives no feedback if path provided is invalid
2 participants
@dignifiedquire @flub