Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: strip down the iroh runtime #1114

Merged
merged 1 commit into from
Jun 21, 2023
Merged

refactor: strip down the iroh runtime #1114

merged 1 commit into from
Jun 21, 2023

Conversation

rklaehn
Copy link
Contributor

@rklaehn rklaehn commented Jun 20, 2023

and use tokio_util::task::LocalPoolHandle instead

https://docs.rs/tokio-util/latest/tokio_util/task/struct.LocalPoolHandle.html

it is basically the same thing, but we can split up iroh more easily without having to have an iroh-runtime crate.

…PoolHandle instead

https://docs.rs/tokio-util/latest/tokio_util/task/struct.LocalPoolHandle.html

it is basically the same thing, but we can split up iroh more easily without
having to have an iroh-runtime crate.
Copy link
Contributor

@dignifiedquire dignifiedquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, that makes things simpler 😅

@rklaehn
Copy link
Contributor Author

rklaehn commented Jun 21, 2023

wow, that makes things simpler 😅

I am totally not emotionally attached to that code... Less code is more good!

@rklaehn rklaehn merged commit 80e8eca into main Jun 21, 2023
@rklaehn rklaehn deleted the local-pool-handle branch June 21, 2023 07:38
matheus23 pushed a commit that referenced this pull request Nov 14, 2024
…PoolHandle instead (#1114)

https://docs.rs/tokio-util/latest/tokio_util/task/struct.LocalPoolHandle.html

it is basically the same thing, but we can split up iroh more easily without
having to have an iroh-runtime crate.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants