tests: Add test utilities to configure logging #1060
Conversation
This is useful in many tests, not just netcheck. Make it more globally available. It also makes it better to enable by default: it just always logs all modules on the TRACE level. But it is properly captured by the test runner and only shown if the test fails. Potentially this is too verbose for some tests. Variants can be built that allow configuring the logging level or even per-modules logging level as required. But no need for that just yet.
src/test_utils.rs
Outdated
| pub(crate) fn setup_logging() -> tracing::subscriber::DefaultGuard { | ||
| let log_layer = tracing_subscriber::fmt::layer() | ||
| .with_writer(|| TestWriter) | ||
| .with_filter(LevelFilter::TRACE); |
There was a problem hiding this comment.
So it is no longer possible to configure log level with RUST_LOG? I find trace to be a bit too much usually...
There was a problem hiding this comment.
yeah, being able to use RUST_LOG for filtering would be great
|
I think this will somewhat interfere with my workflow. I like to use println!, but that will now be drowned in all the log msgs. Also, I find it useful to dial the log level using RUST_LOG=info/error/debug to get an overview. Can we change it to pick up RUST_LOG again, with trace being the default if the env var is not set? |
|
PTAL: I updated this to use RUST_LOG if it is present but fall back to logging everything on trace level if it is not set. This allows us full logs on CI but still let's us customise it when manually poking at things. |
This is useful in many tests, not just netcheck. Make it more globally available.
It also makes it better to enable by default: it just always logs all modules on the TRACE level. But it is properly captured by the test runner and only shown if the test fails.
Potentially this is too verbose for some tests. Variants can be built that allow configuring the logging level or even per-modules logging level as required. But no need for that just yet.