tests(ipv6): Do not run IPv6 tests if the host doesn't support IPv6 #1059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems some of the cross environments simply don't do IPv6 at all. In that case there's no point in supporting IPv6.
| @@ -254,6 +254,9 @@ mod tests { | |||
|
|
|||
| #[tokio::test] | |||
| async fn test_rebinding_conn_send_recv_ipv6() -> Result<()> { | |||
| if !crate::hp::netcheck::os_has_ipv6().await { | |||
| return Ok(()); | |||
There was a problem hiding this comment.
maybe a eprintln that this is being skipped? I wish there was a clearer way to communicate this..
There was a problem hiding this comment.
an eprinln is also captured by default though, so you won't see this unless the test fails (which won't happen) or you use --nocapture. it's not much of an improvement.
There was a problem hiding this comment.
are you sure? asfaik stderr is printed in tests
There was a problem hiding this comment.
yes, I tested it again. both stdout and stderr are captured in tests and not displayed unless the test fails.
I also wish we had a decent way to write a better test harness in rust, the reporting options are just not enough.
dignifiedquire
approved these changes
Jun 1, 2023
matheus23
pushed a commit
that referenced
this pull request
Nov 14, 2024
…1059) Seems some of the cross environments simply don't do IPv6 at all. In that case there's no point in supporting IPv6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems some of the cross environments simply don't do IPv6 at all. In
that case there's no point in trying IPv6.