metrics(netcheck): Add the basic netcheck metrics #1048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the basic metrics to netcheck. There's probably room for more. Also updates the macros to be a bit more ergonomic: - Allow optional trailing comma on the last item in the metrics definition. - When using metrics start a new scope for the compiler so that we can use it anywhere, e.g. also in match statements where the expression is followed with a , rather than a ;. Closes #927
dignifiedquire
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the basic metrics to netcheck. There's probably room for
more.
Also updates the macros to be a bit more ergonomic:
Allow optional trailing comma on the last item in the metrics
definition.
When using metrics start a new scope for the compiler so that we can
use it anywhere, e.g. also in match statements where the expression
is followed with a , rather than a ;.
Closes #927