ref(netcheck): make netcheck a long-running actor #1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is very much WIP, but shows how the netcheck can be a long-running actor. Much cleanup needed.
src/hp/netcheck.rs
Outdated
| self.current_check_run.take(); | ||
| } | ||
| ActorMessage::StunPacket { payload, from_addr } => { | ||
| // TODO: drop package if no check is running |
There was a problem hiding this comment.
no, first thing in the handle function does exactly that
| let skip_external = self.skip_external_network; | ||
| let resolver = self.dns_resolver.clone(); // not a cheap clone, maybe Arc it | ||
| let addr = self.addr(); | ||
| tokio::spawn(async move { |
There was a problem hiding this comment.
Would be nice to track this task, and make sure it gets aborted on drop as well
There was a problem hiding this comment.
Yeah, I was wondering about that as well. But kind of wanted to defer that to a followup PR. Created #1037 for this as there's a few options to consider.
dignifiedquire
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This turns the netcheck into a long running actor:
Clientcreates the actor which runs in a background tokio task.Clientcan be cloned to get more handles to the netcheck actor.Clientis dropped the actor is stopped.This last point is the motivation, it simplifies how things are wired up and makes it easier to keep the right state in the netcheck actor where it belongs. This will also make future changes to netcheck more contained.
It turns the former netcheck actor into more of a full-scale actor. The
ReportStateis not following this pattern yet.