fix(netcheck): Do not read from main Conn sockets #1017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The get_report function is passed the primary Conn sockets so they can be used to send STUN messages from. However these sockets should not be read from directly, Conn already passes through the STUN payloads. Reading from them directly will lose packets in Conn. When the sockets are not passed in however we should create them ourselves, and read from them. The payloads are now received by the actor in the same way as otherwise, removing a lot of Option<>s.
dignifiedquire
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The get_report function is passed the primary Conn sockets so they can
be used to send STUN messages from. However these sockets should not
be read from directly, Conn already passes through the STUN payloads.
Reading from them directly will lose packets in Conn.
When the sockets are not passed in however we should create them
ourselves, and read from them. The payloads are now received by the
actor in the same way as otherwise, removing a lot of Option<>s.