Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

netcheck: fix stun reading from magicsock #1011

Closed
flub opened this issue May 15, 2023 · 1 comment
Closed

netcheck: fix stun reading from magicsock #1011

flub opened this issue May 15, 2023 · 1 comment
Assignees
@flub
Labels
hole punching
Milestone
v0.5.0 - Connecti...

Comments

@flub
Copy link
Contributor

flub commented May 15, 2023

Currently netcheck reads from the magicsock udp & udp6 sockets directly, discarding anything that's not a stun packet. This loses real packets transferring data.

netcheck should only use the stun sockets to send. Only if it was not given any socket to send from should it bind sockets itself and both send and receive from those sockets.
@flub flub self-assigned this May 15, 2023
@flub flub closed this as completed May 17, 2023
@flub
Copy link
Contributor Author

flub commented May 17, 2023

Done in #1022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flub flub

Labels
hole punching
Projects
None yet
Milestone
v0.5.0 - Connectivity intensifies
Development

No branches or pull requests
1 participant
@flub