Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlatBuffersMemoryReader leaks #5

Open
john-wallace-apps opened this issue May 14, 2017 · 0 comments
Open

FlatBuffersMemoryReader leaks #5

john-wallace-apps opened this issue May 14, 2017 · 0 comments

Comments

@john-wallace-apps
Copy link

john-wallace-apps commented May 14, 2017

In the generated FlatbuffersMemoryReader, the code reads:

    deinit {
        if let originalBuffer = originalBuffer,
            let pointer = originalBuffer.baseAddress {
            pointer.deinitialize(count: count)
        }
    }

Instead it should be:

    deinit {
        if let originalBuffer = originalBuffer,
            let pointer = originalBuffer.baseAddress {
            pointer.deallocate(capacity: count)
        }
    }

The deinitialize() method turns initialized memory into unintialized memory, it does not deallocate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant