Improve error handling #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -13,6 +15,8 @@ module.exports = function settle(resolve, reject, response) { | |||
| if (!response.status || !validateStatus || validateStatus(response.status)) { | |||
| resolve(response); | |||
| } else { | |||
| reject(response); | |||
| var error = createError('Request failed with status code ' + response.status, response.config); | |||
| error.response = response; | |||
There was a problem hiding this comment.
I would change this to pass response in as 4th arg to createError.
|
This would have required a note in the |
This was referenced Jun 14, 2016
|
Breaking changes should mean a major version change. |
|
@misund once we hit 1.0 this will definitely be the case. Until then as the API becomes more hardened, breaking changes will be released as new minor versions. There is a note in the README regarding this https://github.com/mzabriskie/axios#semver. |
|
Thanks |
Closed
|
I've opened PR #416 in an attempt to add this note. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #24 and #242.
Breaking change: Promise is now rejected with an
Errorrather than the response object.