style(content): Convert technique
and weapon_category
JSON strings to arrays
#5577
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Required
main
so it won't cause conflict when updatingmain
branch later.Optional
Purpose of change
Convert to use JSON arrays for item
techniques
andweapon_category
. For most items, these properties are typed as an array of strings. This PR updates all those that are typed as just a string.This resolves some issues on the Hitchhiker's Guide to the Cataclysm where it expects
technique
andweapon_category
to bestring[]
types.Describe the solution
Similar changes were made to CDDA in the past, which were referenced for these changes.
Describe alternatives you've considered
I had considered handling both
string
andstring[]
types from the Hitchhiker's Guide, but it seemed simpler and cleaner to handle them upstream here. In addition, this seemed like an inconsistency within CBN's JSON files anyways.Testing
Existing tests all passed.
Additional context