Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(content): Convert technique and weapon_category JSON strings to arrays #5577

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

sangh42
Copy link
Contributor

@sangh42 sangh42 commented Oct 16, 2024

Checklist

Required

Optional

Purpose of change

Convert to use JSON arrays for item techniques and weapon_category. For most items, these properties are typed as an array of strings. This PR updates all those that are typed as just a string.

This resolves some issues on the Hitchhiker's Guide to the Cataclysm where it expects technique and weapon_category to be string[] types.

Describe the solution

Similar changes were made to CDDA in the past, which were referenced for these changes.

Describe alternatives you've considered

I had considered handling both string and string[] types from the Hitchhiker's Guide, but it seemed simpler and cleaner to handle them upstream here. In addition, this seemed like an inconsistency within CBN's JSON files anyways.

Testing

Existing tests all passed.

Additional context

@github-actions github-actions bot added docs PRs releated to docs page JSON related to game datas in JSON format. mods PR changes related to mods. labels Oct 16, 2024
Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice.

@chaosvolt chaosvolt merged commit 8cadc6f into cataclysmbnteam:main Oct 16, 2024
9 checks passed
@sangh42 sangh42 deleted the json-strings-as-arrays branch October 16, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs PRs releated to docs page JSON related to game datas in JSON format. mods PR changes related to mods.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Page for machete and bone machete can not be opened. Can't open weapon categories
3 participants