Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider generating MAPIT_ID_WHITELIST #1023

Open
davewhiteland opened this issue Feb 17, 2015 · 1 comment
Open

consider generating MAPIT_ID_WHITELIST #1023

davewhiteland opened this issue Feb 17, 2015 · 1 comment

Comments

@davewhiteland
Copy link
Contributor

When I've used the MAPIT_ID_WHITELIST recently (hitting our custom international install, not the global/OSM one) really I was entering the IDs of areas with a matching country tag. But often this has felt a bit manual: it's not the IDs I care about, but typically their inclusion in a country.

Of course the unusual thing about this is that the country borders can very easily be part of MapIt's data (certainly in global.mapit). So that suggests what I really want is to put everything that's within a nominated boundary (and with the matching MAPIT_TYPES).

So how about specifying MAPIT_BOUNDARY_ID so that FMS can hit MapIt with an /area/MAPIT_BOUNDARY_ID/covers call, and filter out all the IDs so only those with the required MAPIT_TYPES remain, and so construct the whitelist?

Even if this isn't automatic within FMS, it might be a handy wee script to create the ID list for pasting into conf/general.yml.

Just an idea cos I typed close to 20 IDs into a MAPIT_ID_WHITELIST and thought, hmm.

@dracos
Copy link
Member

dracos commented Feb 17, 2015

covers can be very slow so I don't think would work for general use; a script would be preferable. The whitelist IDs don't really seem necessary for any other install but one that has many different areas of the same type and you don't want to see them all (ie. global OSM). I would have thought you could use different types if you're hosting multiple things in one installation? Or alternatively add a country parameter filter to MapIt calls. Could that work for global MapIt too, I don't know, it's mentioned at mysociety/mapit#55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants