[#8369] Refactor timeline method in AdminGeneralController #8458
+42
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduce get_timeline_events method for improved timeline event fetching - Improve pagination handling for better performance limiting the amount of data loaded into memory - Optimize SQL queries using UNION ALL for combined event types - Separate logic for authority changes and info request events - Remove redundant code and simplify overall structure Fixes #8369
gbp
force-pushed
the
8369-admin-timeline
branch
from
d9116aa
to
c71395e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Fixes #8369
Supersedes #8370
What does this do?
Refactor timeline method in AdminGeneralController
Why was this needed?
Using the "All time" filter on the admin event timeline caused performance issues on sites with a large history.
Notes to reviewer
Found this branch locally work was done back in Aug.
[skip changelog]