Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check zero value return from strtoull calls and return or throw as parse error #2

Open
paulshapiro opened this issue Aug 29, 2018 · 0 comments
Open

Check zero value return from strtoull calls and return or throw as parse error #2

paulshapiro opened this issue Aug 29, 2018 · 0 comments
Labels
good first issue Good for newcomers

Comments

@paulshapiro
Copy link
Contributor

Referring to the fact that uint64_t et al types are transported as strings but strtoull() call return values are not checked for 0ULL

e.g.

mymonero-core-cpp/src/serial_bridge_index.cpp

Line 518 in 95f140f

stoull(json_root.get<string>("sending_amount")),

@paulshapiro paulshapiro added the good first issue Good for newcomers label Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@paulshapiro