Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using without mixin #29

Closed
wants to merge 2 commits into from
Closed

Using without mixin #29

wants to merge 2 commits into from

Conversation

yzx9
Copy link
Contributor

@yzx9 yzx9 commented Nov 19, 2019

  • export function htmlToPaper for using plugin without mixin, we can use it in JS file now
  • epxort function setOptions for change options dynamically

close #22 #25

@yzx9 yzx9 mentioned this pull request Nov 20, 2019
Merged
@yzx9
Copy link
Contributor Author

yzx9 commented Nov 20, 2019

I think htmlToPaper(id, option): Promise<boolean> may be more practical, but it takes a BREAKING CHANGE

jofftiquez
jofftiquez requested changes Feb 12, 2020
View reviewed changes
Copy link
Member

@jofftiquez jofftiquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve conflicts thanks

yzx9 added a commit to yzx9/vue-html-to-paper that referenced this pull request Feb 13, 2020
@yzx9
feat: use without adding instance properties
2b2d60c 
- export htmlToPaper func
- improve option logic

close mycurelabs#29
@yzx9 yzx9 mentioned this pull request Feb 13, 2020
Closed
@jofftiquez
Copy link
Member

Will merge this to a different branch to resolve conflicts and test separately.

@yzx9
Copy link
Contributor Author

yzx9 commented Jun 14, 2023

@jofftiquez hey, does is it still work? II'm willing to fix conflicts if needed.

@jofftiquez
Copy link
Member

Since #22 and #25 are already closed, I think it we can close this as well. Thank you @yzx9 💪

@jofftiquez jofftiquez closed this Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jofftiquez jofftiquez jofftiquez requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to call $htmlToPaper in js file ?
2 participants
@yzx9 @jofftiquez